[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 14 10:43:05 PDT 2019


clayborg added a comment.

I would rather see this stuff just moved into NativeProcessWindows (or some class in the windows lldb-server plug-in) and have all code in ProcessWindow.cpp and ProcessDebugger.cpp go away once lldb-server works on windows? The goal is to get rid of the ProcessWindows.cpp once lldb-server is running. Better to not maintain two different plug-ins (one for native and one for remote). The remote version will always work less well in that case.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63166/new/

https://reviews.llvm.org/D63166





More information about the lldb-commits mailing list