[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 13 18:24:58 PDT 2019


aprantl created this revision.
aprantl added reviewers: davide, JDevlieghere.
Herald added a project: LLDB.

Side question: do we need to do this on every subprocess.check_output() in this file?

rdar://problem/51464644


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63311

Files:
  lldb/examples/python/crashlog.py


Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -326,7 +326,7 @@
                 try:
                     dsym = subprocess.check_output(
                         ["/usr/bin/mdfind",
-                         "com_apple_xcode_dsym_uuids == %s"%uuid_str])[:-1]
+                         "com_apple_xcode_dsym_uuids == %s"%uuid_str]).decode("utf-8")[:-1]
                     if dsym and os.path.exists(dsym):
                         print(('falling back to binary inside "%s"'%dsym))
                         self.symfile = dsym


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63311.204680.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190614/b767c765/attachment-0001.bin>


More information about the lldb-commits mailing list