[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 12 23:31:27 PDT 2019
labath added inline comments.
================
Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170
+
+Status ProcessDebugger::AttachProcess(lldb::pid_t pid,
+ const ProcessAttachInfo &attach_info,
+ DebugDelegateSP delegate) {
----------------
BTW, looking at the other patch, I just realized that this api is extremely redundant:
a) `ProcessAttachInfo` already contains a `pid` field so passing it separately makes no sense
b) `DebuggerThread` does not seem to be doing anything with the ProcessAttachInfo struct anyway.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63166/new/
https://reviews.llvm.org/D63166
More information about the lldb-commits
mailing list