[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 11 21:39:49 PDT 2019


JDevlieghere added a comment.

Have you considered making just `AddExceptionPrecondition` virtual? Wouldn't that solve the problem too, without the code duplication of making `CreateExceptionBreakpoint` virtual? Also, I think it's totally reasonable to hoist `BreakpointPrecondition` out of `Breakpoint`. After having had to deal with the nuisance of not being able to forward declare nested classes, I try to avoid them in general.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63181/new/

https://reviews.llvm.org/D63181





More information about the lldb-commits mailing list