[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

Fri Jun 7 02:28:04 PDT 2019

labath added a comment.

In D62502#1533490 <https://reviews.llvm.org/D62502#1533490>, @aadsm wrote:

> @labath that's a really good point. I've talked with @clayborg  and @xiaobai about this and we decided it would be fine to do it manually as well so I added a `XMLEncodeAttributeValue` function to make it happen. I'm not 100% sure about its implementation.. Should I use a StreamString instead?

The implementation is fine, just make it take a StringRef instead of a char pointer.

The thing I'm not sure about is the location, as now this is the only function in XML.h that actually works without libxml support. Given that this is something we don't want to advertise too broadly, maybe you could just make it a static function GDBRemoteCommunicationServerLLGS? If this trick stays limited to lldb-server (which I think it should), then that could even be the right place for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62502/new/

https://reviews.llvm.org/D62502