[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

[António Afonso via Phabricator via lldb-commits]

aadsm updated this revision to Diff 203476.
aadsm added a comment.
Herald added a subscriber: emaste.

This creates a NativeProcessELF to deal with ELF specific things. The NativeProcessLinux now extends this one.
Added a test case for the GetAuxValue and GetELFImageInfoAddress. I refactored NativeProcessTestUtils to reuse that code.
I also addressed other comments on the review.

Note about the tests: I only have one test for the GetELFImageInfoAddress that follows the 32bit version and also makes sure we correctly read the load bias. Tbh I'm not sure if this is enough but should be easy to add more cases now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62501/new/

https://reviews.llvm.org/D62501

Files:
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.h
  lldb/source/Plugins/Process/POSIX/CMakeLists.txt
  lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
  lldb/source/Plugins/Process/POSIX/NativeProcessELF.h
  lldb/unittests/Host/NativeProcessProtocolTest.cpp
  lldb/unittests/Host/NativeProcessTestUtils.h
  lldb/unittests/Process/CMakeLists.txt
  lldb/unittests/Process/POSIX/CMakeLists.txt
  lldb/unittests/Process/POSIX/NativeProcessELFTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62501.203476.patch
Type: text/x-patch
Size: 30325 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190607/e0af060e/attachment-0001.bin>