[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz marked 3 inline comments as done.
sgraenitz added inline comments.


================
Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67
+    append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs)
+    find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH)
   endif()
----------------
stella.stamenova wrote:
> sgraenitz wrote:
> > How is this working on Windows anyway? It should be `llvm-tblgen.exe` there right?
> Ah, good point. You should use `llvm-tblgen${HOST_EXECUTABLE_SUFFIX}` as the name. That will add the suffix when required.
Ok added the suffix. I can imaging CMake would do it automatically if necessary, but it's not documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62879/new/

https://reviews.llvm.org/D62879