[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz marked an inline comment as done.
sgraenitz added a comment.

After figuring out D62879 <https://reviews.llvm.org/D62879> that came up on the way, this wasn't too complicated indeed. I put the patch for exporting `LLVM_CONFIGURATION_TYPES` here: D62878 <https://reviews.llvm.org/D62878>



================
Comment at: lldb/lit/CMakeLists.txt:13
+    # Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided
+    # LLVM build-tree used a single-configuration generator like Ninja.
+    string(REPLACE ${CMAKE_CFG_INTDIR} "." LLDB_DOTEST_ARGS "${LLDB_DOTEST_ARGS}")
----------------
stella.stamenova wrote:
> It looks like you need the update here also. Is there a way to share the logic between the two cmake files?
> 
> You probably no longer need the xcode pivot either, right?
Thanks for catching this one! Ok deal, I remove the Xcode restriction and you run a test with VS? ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62859/new/

https://reviews.llvm.org/D62859