[Lldb-commits] [PATCH] D62812: [llvm] [CodeView] Move Triple::ArchType → CPUType mapping from LLDB

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:147
+    return CPUType::ARM64;
+  default:
+    return CPUType::X64;
----------------
compnerd wrote:
> This is still wrong.  `x86` and `armv7` are totally legitimate values.  Furthermore, x86 is still far more prevalent on Windows.
Could you be more specific, please? Are you asking me to cover more input values?

Which option do you suggest mapping x86 into? Pentium3?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62812/new/

https://reviews.llvm.org/D62812