[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This looks fine to me.

For context, ObjC has symbols that point into the runtime that tell you things like the current offsets of the members of an ObjC class.  In debug builds the symbols are present, but the runtime doesn't depend on the symbols per se, since it reads the data directly from the runtime.  The symbol names are constructed from the class & ivar name so they are a convenient way to name the data you are looking for.  The lldb does "look for the symbol and if you don't find it ask the runtime if it knows where the equivalent data lives directly in the runtime.".  The latter task is "LookupRuntimeSymbol".

We don't do it this way in swift, instead we ask RemoteAST for this sort of data.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62795/new/

https://reviews.llvm.org/D62795