[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 3 18:27:19 PDT 2019
jingham added a comment.
I have no problem with the change in general. However, you've introduced the possibility of name collision between convenience type definition in various languages. So it would be good to run through the persistent DECL's for ALL the supported languages and report collisions. Probably also need to add a -l flag to pick a language?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62797/new/
https://reviews.llvm.org/D62797
More information about the lldb-commits
mailing list