[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

Mon Jun 3 09:59:21 PDT 2019

xiaobai added a comment.

In D62795#1527035 <https://reviews.llvm.org/D62795#1527035>, @labath wrote:

> If this is supposed to be truly language-agnostic, shouldn't we be iterating over all language plugins and asking all of them for the "runtime symbol" (not that I know what a runtime symbol is, really)?
>
> Otherwise, this is still language-specific behavior, even though it's not visible to the linker because it's hidden by an enum and a virtual interface.

Mmm, yes, you're right, that should be happening. The function is `FindInRuntimes`, not `FindInObjCRuntime` after all. Thanks for pointing that out, let me change that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62795/new/

https://reviews.llvm.org/D62795