[Lldb-commits] [PATCH] D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/trunk/include/lldb/Core/FormatEntity.h:44
       ParentString,
-      InsertString,
+      EscapeCode,
       Root,
----------------
InsertString is used for more than just escape codes so it is now not named correctly. For a variable formatter string like "(${var.x}, ${var.y})", the "(" is a string, and ", " and ")" are InsertString objects. Any constant string that is part of a formatter. Can you change the name back?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62714/new/

https://reviews.llvm.org/D62714