[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read	packet
    Pavel Labath via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Mon Jun  3 02:52:43 PDT 2019
    
    
  
labath added a comment.
Regarding the test, I am wondering whether requiring the `/proc/%d/maps` and the linker rendezvous structure to match isn't too strict of a requirement. Dynamic linkers (and particularly android dynamic linkers) do a lot of crazy stuff, and trying to assert this invariant exposes us to all kinds of "optimizations" that the linkers do or may do in the future. I'm wondering if it wouldn't be better to just build an executable with one or two dependent libraries, and then just assert that their entries are present in the library list. However, I'm not completely sure on this, so I'd like to hear what you think about that..
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62502/new/
https://reviews.llvm.org/D62502
    
    
More information about the lldb-commits
mailing list