[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The idea seems right, but I'm not too familiar with this part of the code. Someone else ought to look at this too.



================
Comment at: include/lldb/Expression/ExpressionVariable.h:235-236
 
+  virtual bool SetCompilerTypeFromPersistentDecl(ConstString type_name,
+                                                 CompilerType &compiler_type) = 0;
+
----------------
It would be better if this would return `Optional`(or `Expected`)`<CompilerType>`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62797/new/

https://reviews.llvm.org/D62797