[Lldb-commits] [lldb] r362107 - Remove length modifier when using assignment suppression in TimerTest

Antonio Afonso via lldb-commits lldb-commits at lists.llvm.org
Thu May 30 08:38:05 PDT 2019


Author: aadsm
Date: Thu May 30 08:38:05 2019
New Revision: 362107

URL: http://llvm.org/viewvc/llvm-project?rev=362107&view=rev
Log:
Remove length modifier when using assignment suppression in TimerTest

Summary:
This is useless and it's giving warnings in the build bots:
/home/motus/netbsd8/netbsd8/llvm/tools/lldb/unittests/Utility/TimerTest.cpp:67:43: warning: use of assignment suppression and length modifier together in gnu_scanf format [-Wformat=]

Reviewers: xiaobai

Subscribers: krytarowski, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D62626

Modified:
    lldb/trunk/unittests/Utility/TimerTest.cpp

Modified: lldb/trunk/unittests/Utility/TimerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/TimerTest.cpp?rev=362107&r1=362106&r2=362107&view=diff
==============================================================================
--- lldb/trunk/unittests/Utility/TimerTest.cpp (original)
+++ lldb/trunk/unittests/Utility/TimerTest.cpp Thu May 30 08:38:05 2019
@@ -62,7 +62,7 @@ TEST(TimerTest, CategoryTimes2) {
   Timer::DumpCategoryTimes(&ss);
   double seconds1, seconds2;
   ASSERT_EQ(2, sscanf(ss.GetData(),
-                      "%lf sec (total: %*lfs; child: %*lfs; count: %*d) for "
+                      "%lf sec (total: %*fs; child: %*fs; count: %*d) for "
                       "CAT1%*[\n ]%lf sec for CAT2",
                       &seconds1, &seconds2))
       << "String: " << ss.GetData();
@@ -98,7 +98,7 @@ TEST(TimerTest, CategoryTimesStats) {
   ASSERT_EQ(
       6, sscanf(ss.GetData(),
                 "%lf sec (total: %lfs; child: %lfs; count: %d) for CAT1%*[\n ]"
-                "%lf sec (total: %*lfs; child: %*lfs; count: %d) for CAT2",
+                "%lf sec (total: %*fs; child: %*fs; count: %d) for CAT2",
                 &seconds1, &total1, &child1, &count1, &seconds2, &count2))
       << "String: " << ss.GetData();
   EXPECT_NEAR(total1 - child1, seconds1, 0.002);




More information about the lldb-commits mailing list