[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

Wanyi Ye via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 1 16:55:56 PDT 2019


kusmour marked 2 inline comments as done.
kusmour added inline comments.


================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:3915
+bool ClangASTContext::CanPassInRegisters(const CompilerType &type) {
+  if (clang::RecordDecl *record_decl = 
+      ClangASTContext::GetAsRecordDecl(type)) {
----------------
compnerd wrote:
> I think that using `auto` instead of `clang::RecordDecl` here is fine as you are already spelling that out in the `ClangASTContext::GetAsRecordDecl`.
got it


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62702/new/

https://reviews.llvm.org/D62702





More information about the lldb-commits mailing list