[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

Sat Jun 1 01:17:29 PDT 2019

TomTan added a comment.

In D62772#1526145 <https://reviews.llvm.org/D62772#1526145>, @mgorny wrote:

> Are you sure this triple → CPUType mapping belongs in each consumer? Maybe it'd be better to have something inside LLVM, so that we wouldn't have to keep this up-to-date in all the places. Maybe `getRegisterNames()` overload that takes a triple?

The CodeView APIs seems not aware of LLVM tripe. `CPUType` comes from CodeView which makes this API self-consistent.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62772/new/

https://reviews.llvm.org/D62772