[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

Fri May 31 17:10:50 PDT 2019

xiaobai added a comment.

In D62755#1525890 <https://reviews.llvm.org/D62755#1525890>, @aprantl wrote:

> Those are good goals. Thank you for working on this!

Thank you for taking the time to review this and discuss this with me! :)

> I don't yet see the connection between those goals and this patch, but I might be missing something. Would CPPLanguageRuntime need to be anything but a forward declaration in Process.h?

Apologies for not making this clearer. I view this patch as a step in moving all non-plugin libraries over to using the LanguageRuntime interface instead of using CPPLanguageRuntime and ObjCLanguageRuntime directly. This particular patch is a part of making Target more language agnostic, as I've been doing over the past few weeks. Here are some other commits that I've recently made towards that goal: rL362164 <https://reviews.llvm.org/rL362164>, rL362154 <https://reviews.llvm.org/rL362154>, rL361999 <https://reviews.llvm.org/rL361999>, rL360945 <https://reviews.llvm.org/rL360945>.

Somewhat related, earlier this month I made the Breakpoint library language agnostic with rL360509 <https://reviews.llvm.org/rL360509>. This is what I want to do, but for each of the non-plugin libraries (e.g. Target).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62755/new/

https://reviews.llvm.org/D62755