[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 31 15:46:07 PDT 2019


jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This seems like carrying purity a little too far.  You haven't removed the fact that the using code is explicitly dialing up the C++ language runtime, you've just made the call-site a little harder to read.

I don't see any problem with having explicit accessors for the commonly used language runtimes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62755/new/

https://reviews.llvm.org/D62755





More information about the lldb-commits mailing list