[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

[Wanyi Ye via Phabricator via lldb-commits]

kusmour marked an inline comment as done.
kusmour added inline comments.


================
Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1568
+// return false if the aggregate is in memory
+static bool FlattenAggregateType(
+    ExecutionContext &exe_ctx,
----------------
compnerd wrote:
> I really wish that we could just use `CGFunctionInfo::getReturnInfo().getKind()`
that's clang. I can try simplify it using ·GetFieldAtIndex·. this just incase we need to check `child_is_base_class`


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62702/new/

https://reviews.llvm.org/D62702