[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 29 02:16:58 PDT 2019


labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:372
+    return std::move(*expected_ranges);
+  unit.GetSymbolFileDWARF()->GetObjectFile()->GetModule()->ReportError(
+      "{0x%8.8x}: DIE has DW_AT_ranges(0x%" PRIx64 ") attribute, but "
----------------
JDevlieghere wrote:
> Can we add a test that ensures we actually display this error?
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62302/new/

https://reviews.llvm.org/D62302





More information about the lldb-commits mailing list