[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 29 01:55:18 PDT 2019


labath added a comment.

In D62500#1519658 <https://reviews.llvm.org/D62500#1519658>, @JDevlieghere wrote:

> > A third option would be to create a completely new library for this. In the past we've talked about a new library for "classes describing various properties of a process", where we'd have MemoryRegionInfo, ProcessInfo, etc, but so far it hasn't materialized. It seems like this could fit nicely into this description, so we could start with the new library with this class. + at JDevlieghere for any thoughts on this.
>
> Do you mean having `AuxVector` in this library, or having it take a `ProcessInfo` instead of the `Process` itself?


The first option. The idea would be that "ProcessInfo" describes uids/pids/... of a process, MemoryRegionInfo describes it's memory regions, and AuxVector describes it's, well.. aux vector. UnixSignals, and probably some others could go there too.

OTOH, Process/Utility sounds like a good name for this kind of thing, and some of these classes are already there, so we may want to approach this from the other end, and remove anything that should not be there (RegisterContextLLDB is my first candidate).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62500/new/

https://reviews.llvm.org/D62500





More information about the lldb-commits mailing list