[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

one major issue that still needs to be resolved is we don't know which thread is currently selected in the IDE UI. You can make an example program that has two threads, each with different variables that are available, and then type "foo" where "foo" is a variable that is only available in one of the thread. Switch between the threads and select the one where "foo" isn't available and then type "foo" in the debugger console. We might need to watch for packets in the VS DAP protocol that indicate a thread of frame are selected and set the selected thread and frame when they change. I am bringing this up because now if the user types "foo" and it didn't happen to be a valid variable in the current thread at frame zero, then it will try to run it as an lldb command and the LLDB command interpreter will happily complete a command when given a unique prefix for an LLDB command which might be confusing to users when they type "x" and it tries to run "memory read" in lldb since "x" is an alias.

This is why lldb-vscode is currently coded to requiring a backtick character in the debugger console to indicate we truly do want an LLDB command. Thoughts?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62547/new/

https://reviews.llvm.org/D62547