[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 28 11:23:19 PDT 2019


JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/tools/argdumper/CMakeLists.txt:9
+if(LLDB_BUILD_FRAMEWORK)
+  lldb_add_to_framework(lldb-argdumper)
+endif()
----------------
friss wrote:
> JDevlieghere wrote:
> > Why do we need this in the framework? Is it only there for testing?
> It is definitely use by our process launch code.
I see, apparently it's used from `Host::ShellExpandArguments` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62472/new/

https://reviews.llvm.org/D62472





More information about the lldb-commits mailing list