[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

Thanks for having a look. I'd to focus on the mechanism here and keep the contents of the framework bundle unchanged. Happy to discuss this in separate reviews like D62474 <https://reviews.llvm.org/D62474>.



================
Comment at: lldb/tools/darwin-debug/CMakeLists.txt:6
+if(LLDB_BUILD_FRAMEWORK)
+  lldb_add_to_framework(lldb-argdumper)
+endif()
----------------
friss wrote:
> JDevlieghere wrote:
> > Presumably this should be `darwin-debug`. But do we need it at all?
> I think it has come in handy a handful of times to debug some issues. It's not needed for LLDB to do its job though.
Thanks for catching that one!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62472/new/

https://reviews.llvm.org/D62472