[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 28 08:55:52 PDT 2019
clayborg added a comment.
Minor nit where we are storing name a ConstString but mangled name as "const char *". Fix if needed.
Would be good to verify performance doesn't regress from this somehow. Maybe having a large DWARF file with many types and accessing each type and making sure it is completed via the external AST.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:248
+ clang::StorageClass storage = clang::SC_None;
+ const char *mangled_name = nullptr;
+ ConstString name;
Why is this stored as a "const char *" and "name" below as a ConstString?
CHANGES SINCE LAST ACTION
More information about the lldb-commits