[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

[António Afonso via Phabricator via lldb-commits]

aadsm marked 2 inline comments as done.
aadsm added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/ELFAuxVector.cpp:18
+  lldb::offset_t saved_offset = *offset_ptr;
+  *value = data.GetMaxU64(offset_ptr, data.GetAddressByteSize());
+  return *offset_ptr != saved_offset;
----------------
clayborg wrote:
> ```
> data.GetAddress(offset_ptr);
> ```
I know you pointed this out but I felt weird calling `GetAddress` since that's not the semantic value of the underlying data. That's why I still ended up with GetMaxU64, what do you think?


================
Comment at: lldb/source/Plugins/Process/Utility/ELFAuxVector.h:67
+
+  std::unordered_map<uint64_t, uint64_t> m_auxv_entries;
+};
----------------
clayborg wrote:
> Is there only ever one entry in the AUXV map for each EntryType?
Yes, this was something I was concerned with (since the AuxVector returns an iterator). I checked the "official" API and that's what they assume: http://man7.org/linux/man-pages/man3/getauxval.3.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62500/new/

https://reviews.llvm.org/D62500