[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads
António Afonso via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 28 07:30:55 PDT 2019
aadsm added a comment.
Regarding changing the ReadMemory, yes, I was going to submit another patch with it. I was going to do it in a different way though, where I would read as much as possible with the process_vm_readv (fwiw, this function does not fail when it tries to read cross page, it will just partial read) and then read the rest with ptrace. But I guess it does makes more sense to adopt the same page boundary read strategy.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits