[Lldb-commits] [PATCH] D62517: Revert "D11003: Tolerate DWARF compile unit without filename."

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 28 04:57:47 PDT 2019

labath created this revision.
labath added reviewers: clayborg, tberghammer, dsrbecky.
Herald added a subscriber: aprantl.

This code is modifying a support file list after it has been created.
This makes it hard to share the file list between type units and
compile units in DWARF. It's not a total showstopper, but supporting
this while also sharing the lists would make things more complicated.

Given that this was added to support a project which never fully
materialised, and that even back then there were some concerns about the
correctness of this approach (according to D11003#200772 <https://reviews.llvm.org/D11003#200772> the compile
unit name is not guaranteed to be the first one in the support file
list), I think we should just delete this workaround.



Index: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
--- source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -680,19 +680,6 @@
                 module_sp, dwarf_cu, cu_file_spec, dwarf_cu->GetID(),
                 cu_language, is_optimized ? eLazyBoolYes : eLazyBoolNo);
-            // If we just created a compile unit with an invalid file spec,
-            // try and get the first entry in the supports files from the
-            // line table as that should be the compile unit.
-            if (!cu_file_spec) {
-              cu_file_spec = cu_sp->GetSupportFiles().GetFileSpecAtIndex(1);
-              if (cu_file_spec) {
-                (FileSpec &)(*cu_sp) = cu_file_spec;
-                // Also fix the invalid file spec which was copied from the
-                // compile unit.
-                cu_sp->GetSupportFiles().Replace(0, cu_file_spec);
-              }
-            }

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62517.201640.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190528/ff1e0e60/attachment.bin>

More information about the lldb-commits mailing list