[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

[António Afonso via Phabricator via lldb-commits]

aadsm created this revision.
aadsm added reviewers: clayborg, xiaobai, labath.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
aadsm edited the summary of this revision.
aadsm added a parent revision: D62503: Add ReadCStringFromMemory for faster string reads.

This is the sixth and final patch to improve module loading in a series that started here (where I explain the motivation and solution): D62499 <https://reviews.llvm.org/D62499>

When `xfer:libraries-svr4` is available the Process class has a LoadModules function that requests this packet and then loads or unloads modules based on the current list of loaded modules by the process.
This is function is used by DYLDRendezvous to get the list of loaded modules before and after the module is loaded. However, this is really not needed since the LoadModules function already loaded or unloaded the modules accordingly. I changed this strategy to call LoadModules only once (after the process has loaded the module).
I also removed the `FromRemote` functions & friends because they were only maintaining the `m_soentries` structure that is never being used in this context. (I hope I'm not missing anything obvious here).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62504

Files:
  lldb/include/lldb/Target/Process.h
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62504.201593.patch
Type: text/x-patch
Size: 7631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190527/75cbc5a3/attachment-0001.bin>