[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

Mon May 27 05:22:17 PDT 2019

labath updated this revision to Diff 201515.
labath added a comment.

- reduce the code duplication by adding a helper function. I've elected to put the helper function into DWARFDebugInfoEntry, to keep the DWARFUnit part of this patch identical with the llvm DWARFUnit. I think the main source of duplication here is that DWARFDebugInfoEntry has two very similar methods (GetAttributeAddressRanges and GetDIENamesAndRanges), which both parse DW_AT_ranges. Once that is resolved, we will be able to reduce the duplication and get rid of the helper function.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62302/new/

https://reviews.llvm.org/D62302

Files:
  lit/SymbolFile/DWARF/debug_ranges_and_rnglists.test
  source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFUnit.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62302.201515.patch
Type: text/x-patch
Size: 12943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190527/dfdb9d65/attachment.bin>