[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'
Konrad Wilhelm Kleine via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 23 08:15:05 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361503: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t' (authored by kwk, committed by ).
Herald added a subscriber: abidh.
Changed prior to commit:
https://reviews.llvm.org/D62305?vs=200969&id=200980#toc
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62305/new/
https://reviews.llvm.org/D62305
Files:
source/Core/Communication.cpp
source/Core/Debugger.cpp
source/Host/common/TaskPool.cpp
source/Host/windows/HostProcessWindows.cpp
source/Plugins/Process/Windows/Common/DebuggerThread.cpp
Index: source/Plugins/Process/Windows/Common/DebuggerThread.cpp
===================================================================
--- source/Plugins/Process/Windows/Common/DebuggerThread.cpp
+++ source/Plugins/Process/Windows/Common/DebuggerThread.cpp
@@ -132,7 +132,7 @@
else
m_debug_delegate->OnDebuggerError(error, 0);
- return 0;
+ return {};
}
lldb::thread_result_t DebuggerThread::DebuggerThreadAttachRoutine(
@@ -148,7 +148,7 @@
if (!DebugActiveProcess((DWORD)pid)) {
Status error(::GetLastError(), eErrorTypeWin32);
m_debug_delegate->OnDebuggerError(error, 0);
- return 0;
+ return {};
}
// The attach was successful, enter the debug loop. From here on out, this
@@ -156,7 +156,7 @@
// in DebugLaunch should apply from this point out.
DebugLoop();
- return 0;
+ return {};
}
Status DebuggerThread::StopDebugging(bool terminate) {
Index: source/Host/windows/HostProcessWindows.cpp
===================================================================
--- source/Host/windows/HostProcessWindows.cpp
+++ source/Host/windows/HostProcessWindows.cpp
@@ -109,7 +109,7 @@
::CloseHandle(info->process_handle);
delete (info);
}
- return 0;
+ return {};
}
void HostProcessWindows::Close() {
Index: source/Host/common/TaskPool.cpp
===================================================================
--- source/Host/common/TaskPool.cpp
+++ source/Host/common/TaskPool.cpp
@@ -73,7 +73,7 @@
lldb::thread_result_t TaskPoolImpl::WorkerPtr(void *pool) {
Worker((TaskPoolImpl *)pool);
- return nullptr;
+ return {};
}
void TaskPoolImpl::Worker(TaskPoolImpl *pool) {
Index: source/Core/Debugger.cpp
===================================================================
--- source/Core/Debugger.cpp
+++ source/Core/Debugger.cpp
@@ -1616,7 +1616,7 @@
lldb::thread_result_t Debugger::EventHandlerThread(lldb::thread_arg_t arg) {
((Debugger *)arg)->DefaultEventHandler();
- return nullptr;
+ return {};
}
bool Debugger::StartEventHandlerThread() {
@@ -1661,7 +1661,7 @@
Debugger *debugger = (Debugger *)arg;
debugger->ExecuteIOHandlers();
debugger->StopEventHandlerThread();
- return nullptr;
+ return {};
}
bool Debugger::HasIOHandlerThread() { return m_io_handler_thread.IsJoinable(); }
Index: source/Core/Communication.cpp
===================================================================
--- source/Core/Communication.cpp
+++ source/Core/Communication.cpp
@@ -359,7 +359,7 @@
// Let clients know that this thread is exiting
comm->BroadcastEvent(eBroadcastBitNoMorePendingInput);
comm->BroadcastEvent(eBroadcastBitReadThreadDidExit);
- return nullptr;
+ return {};
}
void Communication::SetReadThreadBytesReceivedCallback(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62305.200980.patch
Type: text/x-patch
Size: 2742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190523/efbb5af5/attachment.bin>
More information about the lldb-commits
mailing list