[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

[Wanyi Ye via Phabricator via lldb-commits]

kusmour marked an inline comment as done.
kusmour added inline comments.


================
Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1096
+  if (arch_type == llvm::Triple::x86_64
+    && os_type == llvm::Triple::OSType::Win32) {
+    return ABISP(new ABIWindows_x86_64(process_sp));
----------------
compnerd wrote:
> Nit: I think that `arch.GetTriple().isOSWindows()` is nicer than the explicit check of `Win32`.
got it



Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62213/new/

https://reviews.llvm.org/D62213