[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:255
     TypeList *type_list = dwarf->GetTypeList();
     if (type_ptr == NULL) {
+
----------------
Not your code, but it would be easier to follow the logic if we pulled these cases up front:

```
  if (type_ptr == DIE_IS_BEING_PARSED)
     return type_sp;
  if (type_ptr)
      return type_ptr->shared_from_this();
...
```


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:258
+      if (DWARFDIE signature_die = die.GetAttributeValueAsReferenceDIE(DW_AT_signature)) {
+        type_sp = ParseTypeFromDWARF(sc, signature_die, log, type_is_new_ptr);
+        if (type_sp) {
----------------
`if (type_sp = ParseTypeFromDWARF(sc, signature_die, log, type_is_new_ptr))`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62246/new/

https://reviews.llvm.org/D62246