[Lldb-commits] [lldb] r361310 - [Test] Fix conflicting test names.

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue May 21 23:42:17 PDT 2019


On 21/05/2019 22:55, Jonas Devlieghere via lldb-commits wrote:
> Author: jdevlieghere
> Date: Tue May 21 13:55:00 2019
> New Revision: 361310
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=361310&view=rev
> Log:
> [Test] Fix conflicting test names.
> 
> Two tests having the same name creates a race condition when moving the
> trace files.
> 

We could just change the default trace file format (specified here: 
https://github.com/llvm-mirror/lldb/blob/master/test/CMakeLists.txt#L44) 
to use the test file name instead of the class name. The test file name 
is already guaranteed to be unique, and I don't believe we use more than 
one test class per file, which means the combination of file name + 
method name should be enough to uniquely identify a test...




More information about the lldb-commits mailing list