[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1073
+bool DWARFDebugInfoEntry::AppendTypeName(const DWARFDIE die, Stream &s) {
+  if (die) {
+    if (die.GetDIE()->IsNULL()) {
----------------
How about turning this into an early return?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:129
 
-  static bool GetName(const DWARFUnit *cu, const dw_offset_t die_offset,
-                      lldb_private::Stream &s);
+  static bool GetName(const DWARFDIE die, lldb_private::Stream &s);
 
----------------
Since we pass by value we can remove the `const`?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62211/new/

https://reviews.llvm.org/D62211