[Lldb-commits] [PATCH] D62061: Add AST logging

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:968
+                 from->getDeclKindName(), static_cast<void *>(to),
+                 name_string.c_str(), static_cast<void *>(from));
+
----------------
The macro uses llvm's format library, so you can omit the calls to `.cstr()`. 


================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:974
+        to->getTranslationUnitDecl()->dump(ast_stream);
+        LLDB_LOG(log_ast, "{0}", ast_string.c_str());
+      }
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62061/new/

https://reviews.llvm.org/D62061