[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added a comment.

Thanks. We can always re-add the check if things take longer than expected.



================
Comment at: lit/SymbolFile/DWARF/debug-types-expressions.test:28
+# CHECK-LABEL: print ns::A()
+# CHECK: (ns::A) $1 = (i = 147)
----------------
aprantl wrote:
> [This is more a meta-point and I don't care very strongly about it]
> For a test of the DWARF parser, is it necessary to actually attach to a running process, or could we statically inspect the types of, e.g., global variables with `target var` or something?
Yes and no. :)

I believe a lot of things can be tested without a running process, and I've tried to make use of that as much as possible. However, it is my understanding (though it's still a fairly fuzzy one) that `target/frame variable` and the expression evaluator use the debug info differently.

That's why I've created two tests here. The "basic" one does not require a running process and can run anywhere. I think of this as the first line of defense. Then, if anything slips past that, there's the "expression" test, which will try to use the debug info from the expression evaluator. That one requires us to be able to generate type units for the target platform (i.e., elf only at the moment).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62008/new/

https://reviews.llvm.org/D62008