[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

[Alexandre Ganea via Phabricator via lldb-commits]

aganea marked 2 inline comments as done.
aganea added inline comments.


================
Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37
+          reinterpret_cast<char *>(const_cast<wchar_t *>(warg.c_str())),
+          reinterpret_cast<char *>(
+              const_cast<wchar_t *>(warg.c_str() + warg.size() + 1)));
----------------
labath wrote:
> I don't believe the const_cast here is needed. You should be able to just reinterpret_cast to `const char *`..
You're right - fixed.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62021/new/

https://reviews.llvm.org/D62021