[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

Gabor Marton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 17 06:28:24 PDT 2019

martong marked an inline comment as done.
martong added inline comments.

Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922
+      Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+      if (log_ast) {
shafik wrote:
> I am going to say that the logging change is an excellent additions and stands alone from this change. Although I realize the test depends on this new feature. It makes sense to add the logging in a separate PR.
> I also say this b/c I found a regression and it would be nice to get the logging in while we resolve the regression.
Ok, I have created a new patch for logging (https://reviews.llvm.org/D62061).
I made this patch to be the child of that and rebased to that.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list