[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

Nico Weber via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 16 17:58:04 PDT 2019


thakis added a comment.

Thanks for the revert!

> So I'm going to revert this to unbreak the Chromium/Android build, and then we can think some more about how we can get the size win without the breakage.

I think by now the Chromium/Android build is a red herring. This drops debug info from thinlto builds in general and makes debugging there worse. It's just that in chromium/android, the debug info was load bearing and hence we noticed there sooner. We should probably set up debug info quality bots using thinlto somewhere, to have a better way of identifying this type of bug.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54747/new/

https://reviews.llvm.org/D54747





More information about the lldb-commits mailing list