[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files
Saleem Abdulrasool via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 16 10:48:00 PDT 2019
compnerd added inline comments.
Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18
+set(LLVM_ENABLE_MODULES ON CACHE BOOL "")
> Can / Should we add this? Here?
This is fine to add assuming that you are building on Darwin since that implies clang and that will work. I would say that if you really want to be pedantically correct, it would be better to do:
if(CMAKE_CXX_COMPILER_ID MATCHES Clang)
set(LLVM_ENABLE_MODULES_ON CACHE BOOL "")
Note that the `MATCHES` is required here to match both `Clang` and `AppleClang`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits