[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd added inline comments.


================
Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18
+set(CMAKE_BUILD_TYPE RelWithDebInfo)
+set(LLVM_ENABLE_MODULES ON CACHE BOOL "")
----------------
sgraenitz wrote:
> Can / Should we add this? Here?
This is fine to add assuming that you are building on Darwin since that implies clang and that will work.  I would say that if you really want to be pedantically correct, it would be better to do:

```
if(CMAKE_CXX_COMPILER_ID MATCHES Clang)
  set(LLVM_ENABLE_MODULES_ON CACHE BOOL "")
endif()
```

Note that the `MATCHES` is required here to match both `Clang` and `AppleClang`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61956/new/

https://reviews.llvm.org/D61956