[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

Thu May 16 10:10:39 PDT 2019

sgraenitz added a comment.

I thought about one more option, but I don't think it's better than the current proposal: instead of deleting the build-tree resources in the very first install step, I could **install the framework manually** at this point and skip its regular install target. We would loose implicit stripping and RPATH replacement for the dylib though. Should be possible to do it manually, but if it breaks, we won't notice. So, it's not quite appealing.

In D61952#1504991 <https://reviews.llvm.org/D61952#1504991>, @labath wrote:

> Because one might want to run the lldb executable independently of the test suite?

Agreed, it would be inconvenient to have non-functional build results. The solution to the "install -> test" issue would be having both I guess.
**Adding this to the current patch still sounds like the most convenient approach to me.**

In D61952#1504941 <https://reviews.llvm.org/D61952#1504941>, @sgraenitz wrote:

> In D61952#1504346 <https://reviews.llvm.org/D61952#1504346>, @labath wrote:
>
> > For instance, what if we set the build output paths to be separate and disjoint locations for each target. Then use a separate target, or some POST_BUILD commands to copy/symlink the files to construct an build-tree framework, and have the install targets create the install-tree framework from the original build output paths?
>
>
> Ok, so you mean copying the entire framework to a staging directory, something like a "test-tree". Then we add test resources and run the test suite there. Sounds reasonable, I will investigate.

In fact, your above comment is more relevant here. I'd have to set all build-tree RPATHs to the staging framework instead of the actual target output. Sounds like a number of non-intuitive edits all over the CMake scripts..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61952/new/

https://reviews.llvm.org/D61952