[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

In D62011#1504877 <https://reviews.llvm.org/D62011#1504877>, @labath wrote:

> Seems like a nice cleanup. Given that code code already assumed that the DWARFUnit can't be null, I'd just delete the null checks..


I have rechecked it now and 2 of the 3 tests are valid, it can be NULL, callers are:

  DWARFDebugInfoEntry::DumpAttribute():
    case DW_AT_abstract_origin:
    case DW_AT_specification: {
      DWARFDIE abstract_die = form_value.Reference();
      GetName(abstract_die.GetCU(), abstract_die.GetOffset(), s);
    case DW_AT_type: {
      DWARFDIE type_die = form_value.Reference();
      AppendTypeName(type_die.GetCU(), type_die.GetOffset(), s);

Sorry for not verifying it myself first.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62011/new/

https://reviews.llvm.org/D62011