[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 16 07:39:48 PDT 2019


jankratochvil marked 3 inline comments as done.
jankratochvil added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:380
+    DWARFExpression *frame_base) const {
+  if (cu == nullptr)
     return false;
----------------
Here is a NULL check.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1055
                                   const dw_offset_t die_offset, Stream &s) {
-  if (dwarf2Data == NULL) {
+  if (cu == NULL) {
     s.PutCString("NULL");
----------------
Here is a NULL check.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1086
                                          Stream &s) {
-  if (dwarf2Data == NULL) {
+  if (cu == NULL) {
     s.PutCString("NULL");
----------------
Here is a NULL check.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62011/new/

https://reviews.llvm.org/D62011





More information about the lldb-commits mailing list