[Lldb-commits] [PATCH] D61502: Permit cross-CU references

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Just a few simplifications to GetName() and AppendTypeName() are in question and can optionally be done if needed.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:699
+    //  *ostrm_ptr << HEX32 << abstract_die.GetOffset() << " ( ";
+    GetName(dwarf2Data, abstract_die.GetCU(), abstract_die.GetOffset(), s);
   } break;
----------------
Should we make GetName() just take a DWARFDIE now?:
```
GetName(abstract_die, s);
```


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:705
     s.PutCString(" ( ");
-    AppendTypeName(dwarf2Data, cu, type_die_offset, s);
+    AppendTypeName(dwarf2Data, type_die.GetCU(), type_die.GetOffset(), s);
     s.PutCString(" )");
----------------
Should we make AppendTypeName() just take a DWARFDIE now?:
```
AppendTypeName(type_die, s);
```


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1199-1200
+          DWARFDIE next_die = form_value.Reference();
+          result = AppendTypeName(dwarf2Data, next_die.GetCU(),
+                                  next_die.GetOffset(), s);
         }
----------------
Should we make AppendTypeName() just take a DWARFDIE now?:
```
AppendTypeName(next_die, s);
```


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61502/new/

https://reviews.llvm.org/D61502