[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 14 18:22:42 PDT 2019
jingham added a comment.
Getting it from the Process's m_language_runtimes is probably fine. On reflection, I can't think of a reason why you would want to iterate over all the available LanguageRuntimes, including the ones that hadn't been recognized in this Process yet.
It's fine to do that in a separate patch. If you do that it would be good to back port it to the other iterations over the LanguageRuntimes.
I don't see a really strong reason to make GetStepThroughTrampolinePlan a pure virtual method, this isn't required behavior for a language runtime. Why not make a default method that returns an empty thread plan?
CHANGES SINCE LAST ACTION
More information about the lldb-commits