[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: source/Target/ThreadPlanStepThrough.cpp:91
+  if (!m_sub_plan_sp) {
+    for (unsigned lang = eLanguageTypeUnknown;
+         !m_sub_plan_sp && lang < eNumLanguageTypes; lang++) {
----------------
 Given that we seem to have this pattern in a bunch of places, would it be worth extracting this into some kind of convenience function?


================
Comment at: source/Target/ThreadPlanStepThrough.cpp:96
+        m_sub_plan_sp =
+            runtime->GetStepThroughTrampolinePlan(m_thread, m_stop_others);
+      }
----------------
Should there be a break here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61921/new/

https://reviews.llvm.org/D61921