[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

Mon May 13 08:09:20 PDT 2019

zloyrobot added a comment.

In D61128#1499934 <https://reviews.llvm.org/D61128#1499934>, @labath wrote:

> Looks like this is failing on the windows bot http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/4635/steps/test/logs/stdio.
>
> Looking at the test, it seems that you are asserting that you will unwind into a particular offset in ntdll.dll. That sounds like an incredibly fragile assertion, which will only be true for people running the exact same version of ntdll that you happen to have...

My bad, these assertions (ntdll and kernel32) should be removed from test. I already asked @aleksandr.urakov to do it.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61128/new/

https://reviews.llvm.org/D61128